Fix Apple Silicon SIGKILL on the darwin binary#19
Merged
Conversation
Cross-compiled (Linux-built) darwin/arm64 binaries are killed at exec by Apple Silicon's kernel despite a valid-on-disk signature. Build the darwin launcher on a macOS runner so it's signed acceptably, and have install.sh ad-hoc re-sign on macOS as a safety net (fixes already-released v2.0.0 installs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-compiled darwin/arm64 binaries get SIGKILLed at exec on Apple Silicon (AMFI rejects the Linux-built signature). Build darwin on a macOS runner so it's signed acceptably; install.sh also ad-hoc re-signs on macOS, which fixes the already-published v2.0.0 (install.sh is fetched live).